Add measurement-set command
#316
Conversation
|
This PR came up while I was doing some debugging for manufacturing programming and I figure if I wanted it once we will probably want it again |
labbott
force-pushed
the
print_measurement_set
branch
from
ac70b56 to
9c4ad21
Compare
verifier/src/lib.rs
Outdated
|
|
||
| impl std::iter::IntoIterator for MeasurementSet { | ||
| type Item = Measurement; | ||
| type IntoIter = <std::collections::HashSet<attest_data::Measurement> as std::iter::IntoIterator>::IntoIter; |
There was a problem hiding this comment.
This is what rust suggested, it's possible I could do this in a less obfuscated way
There was a problem hiding this comment.
Another way is to define an Iterator for MeasurementSet and then impl IntoIterator in terms of that. This seems fine though, and is less code.
There was a problem hiding this comment.
HashSet is already in scope here so you save some characters by dropping the std::collections
verifier-cli/src/main.rs
Outdated
| } | ||
|
|
||
| fn measurement_set(attest: &dyn Attest) -> Result<MeasurementSet> { | ||
| // get log |
There was a problem hiding this comment.
nit: probably don't need this comment
verifier/src/lib.rs
Outdated
|
|
||
| impl std::iter::IntoIterator for MeasurementSet { | ||
| type Item = Measurement; | ||
| type IntoIter = <std::collections::HashSet<attest_data::Measurement> as std::iter::IntoIterator>::IntoIter; |
There was a problem hiding this comment.
Another way is to define an Iterator for MeasurementSet and then impl IntoIterator in terms of that. This seems fine though, and is less code.
It's useful to see what the current set of measurements is on device
labbott
force-pushed
the
print_measurement_set
branch
from
9c4ad21 to
00b9921
Compare
It's useful to see what the current set of measurements is on device